Update FlexFormException.php #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow arg to be null in type hinting
Collaborator
|
You requested a feature not available in php 7 and a merge request to main branch which is not used. I'm guessing it's for the 1_39 and 1_43 branch? |
Author
|
Good to know the main branch isn't used. Nullable types have been introduced in PHP 7.1 and MW 1.35 appears to require PHP 7.3.19+ so it's not specific to MW.39+. P.S. I noticed there are other minor changes that can be suggested. Do you prefer separate commits?
|
D-Groenewegen
added a commit
to a-g-van-hamel-foundation/FlexForm
that referenced
this pull request
Dec 20, 2025
Open-CSP#72 + additional improvements - Allow arg to be null in type hinting - `\Exception` can be simplified to `Exception` - PHP8 complains that `__toString()` is incompatible with `Exception :: __tostring()` because it insists on strict typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow arg to be null in type hinting