Skip to content

fix: do not exceed lifetime of access token in cache#475

Closed
pvbouwel wants to merge 2 commits intomasterfrom
cache-fix
Closed

fix: do not exceed lifetime of access token in cache#475
pvbouwel wants to merge 2 commits intomasterfrom
cache-fix

Conversation

@pvbouwel
Copy link
Copy Markdown
Contributor

No description provided.

@pvbouwel pvbouwel requested a review from soxofaan March 31, 2026 06:06
@pvbouwel
Copy link
Copy Markdown
Contributor Author

Test failure is unrelated to this PR but should be solved with: #477

@soxofaan
Copy link
Copy Markdown
Member

Maybe you also want to add/edit a test on TestClientCredentialsAccessTokenHelper here?

@soxofaan
Copy link
Copy Markdown
Member

soxofaan commented Mar 31, 2026

and you probably want to bump the openeo dependency version in setup.py too (because you depend on new API)

@soxofaan
Copy link
Copy Markdown
Member

and merge master in this feature branch to fix the failing test

@pvbouwel
Copy link
Copy Markdown
Contributor Author

Maybe you also want to add/edit a test on TestClientCredentialsAccessTokenHelper here?

Moved them to this PR

@pvbouwel
Copy link
Copy Markdown
Contributor Author

@soxofaan does it make sense to have _expiration_threshold as an attribute set with default value through initialiser like in my commit?

@soxofaan
Copy link
Copy Markdown
Member

@soxofaan does it make sense to have _expiration_threshold as an attribute set with default value through initialiser like in my commit?

I'm fine with that.

minor nitpick: calling it buffer instead of threshold might be a bit more self-explanatory

@soxofaan
Copy link
Copy Markdown
Member

merged in 8165e0c (with minor fixup)

@soxofaan soxofaan closed this Mar 31, 2026
@soxofaan soxofaan deleted the cache-fix branch March 31, 2026 14:28
@soxofaan soxofaan self-assigned this Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants