Skip to content

Conversation

@jecarey
Copy link

@jecarey jecarey commented Nov 9, 2015

  • Added testfile.txt

@aditirajagopal

@aditirajagopal
Copy link

@jecarey

Was pretty skeptical that this would work. Looks like in order to submit a PR of a "fork of a fork," you need to go to the parent fork's repo page, and submit the PR there. if you do it from your child fork, it will (by default) try to submit a PR for the grandparent repo, and the filter doesn't let you find the parent fork.

What a weird dysfunctional family of repos.

@MHBauer
Copy link

MHBauer commented Nov 9, 2015

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "moxiegirl-patch-README" git@github.com:docker/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f
Ammending updates the existing PR. You DO NOT need to open a new one.

  - Added testfile.txt

Signed-off-by: James Carey <jecarey@us.ibm.com>
@jecarey
Copy link
Author

jecarey commented Nov 9, 2015

@MHBauer added the signature.

@aditirajagopal
Copy link

LGTM!

@MHBauer
Copy link

MHBauer commented Nov 9, 2015

looks good. success!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants