Skip to content

Make session close synchronous and retry only connection-level termination failures#499

Merged
rrobetti merged 4 commits intomainfrom
copilot/investigate-ojp-connection-issues
May 9, 2026
Merged

Make session close synchronous and retry only connection-level termination failures#499
rrobetti merged 4 commits intomainfrom
copilot/investigate-ojp-connection-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 9, 2026

  • Review the last two commits and identify the affected runtime behavior
  • Locate the most relevant docs for connection close and session cleanup behavior
  • Document synchronous close semantics and the 3-attempt retry in JDBC configuration docs
  • Document the same retry behavior in the eBook
  • Validate the documentation changes and reply to the PR comment
  • Run final review/security validation

Copilot AI and others added 2 commits May 9, 2026 12:06
@rrobetti
Copy link
Copy Markdown
Contributor

rrobetti commented May 9, 2026

@copilot document this behaviour including in the eBook but in other doc(s) if relevant. Make it clear that there is a retry.

Copilot AI and others added 2 commits May 9, 2026 12:24
Agent-Logs-Url: https://github.com/Open-J-Proxy/ojp/sessions/65ec2db3-0d64-4509-a604-7e471a9e7aae

Co-authored-by: rrobetti <7221783+rrobetti@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Open-J-Proxy/ojp/sessions/65ec2db3-0d64-4509-a604-7e471a9e7aae

Co-authored-by: rrobetti <7221783+rrobetti@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 9, 2026

@copilot document this behaviour including in the eBook but in other doc(s) if relevant. Make it clear that there is a retry.

Documented in the eBook and the relevant docs. I updated the JDBC config guide, the session cleanup guide, and eBook Chapter 5 to make the synchronous close behavior and the 3-attempt connection-level retry explicit, including the non-retry cases. Commit: a318fd8

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 9, 2026

Copilot AI requested a review from rrobetti May 9, 2026 12:25
@rrobetti rrobetti marked this pull request as ready for review May 9, 2026 12:27
@rrobetti rrobetti merged commit b685653 into main May 9, 2026
1 check passed
@rrobetti rrobetti deleted the copilot/investigate-ojp-connection-issues branch May 9, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants