Conversation
….getConnection() info arg - Add DatasourcePropertiesLoader.applyInfoProperties() to merge any ojp.connection.pool.* / ojp.xa.* keys from the JDBC info Properties with the highest precedence (above env vars, system props, and the file) - Call applyInfoProperties in Driver.connect() immediately after the file/system/env properties are loaded - Add DatasourcePropertiesLoaderInfoPropertiesTest (13 tests) covering null/empty guards, info-only, override, XA, key filtering, and mixed cases - Update documents/configuration/ojp-jdbc-configuration.md with a new "Programmatic Configuration via DriverManager" subsection and priority table - Update documents/ebook/part2-chapter5-jdbc-configuration.md: fix the property reference table (wrong names and defaults), expand the Programmatic Configuration section with the priority table and filtering note Agent-Logs-Url: https://github.com/Open-J-Proxy/ojp/sessions/c5d92d35-acf2-4be2-ad8d-e57ae26b77cb Co-authored-by: rrobetti <7221783+rrobetti@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
rrobetti
May 9, 2026 21:37
View session
|
rrobetti
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Pool configuration keys set in the
Propertiesargument toDriverManager.getConnection(url, info)were silently dropped — the driver read pool settings exclusively fromojp.properties/ system properties / env vars, making programmatic overrides (e.g. dynamically computedmaximumPoolSize) impossible.Changes
DatasourcePropertiesLoader— newapplyInfoProperties(base, info, datasourceName)method that filtersojp.connection.pool.*andojp.xa.*keys frominfoand merges them on top of the already-resolved base with the highest precedence. Non-OJP keys (user,password, database-specific params) are deliberately ignored.Driver.connect()— callsapplyInfoPropertiesimmediately after loading from file/system/env.DatasourcePropertiesLoaderInfoPropertiesTest— 13 new unit tests covering: null/empty guards, info-only (no file present), info overrides base, XA properties, credential key filtering, and mixed scenarios.Docs —
ojp-jdbc-configuration.mdandpart2-chapter5-jdbc-configuration.md: added programmatic configuration section with the four-level priority table; corrected the ebook property reference table (wrong bare names and stale defaults).Priority order after fix
Propertiespassed togetConnection()-D)ojp.propertiesfileUsage