Tapi 2 5 0 fixes #660
Open
Tapi 2 5 0 fixes #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As agreed in issue Open-Network-Models-and-Interfaces-ONMI#619
The following have been adjusted to be require-instance false; In tapi-connectivity.yang - connection-end-point-ref - switch-control-ref - switch-ref - route-ref In tapi-common.yang - profile-ref In tapi-topology.yang - topology-ref - node-ref
| string maintenance_intermediate_point = 13 [json_name = "maintenance-intermediate-point"]; | ||
| string maintenance_end_point = 14 [json_name = "maintenance-end-point"]; | ||
| uint64 measurement_start_time = 15 [json_name = "measurement-start-time"]; | ||
| repeated QualifiedMeasuredValue qualified_measured_value_set = 16 [json_name = "qualified-measured-value-set"]; |
There was a problem hiding this comment.
I think we need to add the following here:
repeated NameAndValue additionalInfo = 17 [json_name = "additional-info"];
And define NameAndValue as:
message NameAndValue {
string valueName = 1 [json_name = "value-name"];
string value = 2;
}
This will be required to be consistent with the yang model in tapi-gnmi-streaming.yang.
| string maintenance_intermediate_point = 13 [json_name = "maintenance-intermediate-point"]; | ||
| string maintenance_end_point = 14 [json_name = "maintenance-end-point"]; | ||
| uint64 measurement_start_time = 15 [json_name = "measurement-start-time"]; | ||
| repeated QualifiedMeasuredValue qualified_measured_value_set = 16 [json_name = "qualified-measured-value-set"]; |
There was a problem hiding this comment.
I think we need to add the following here also:
repeated NameAndValue additionalInfo = 17 [json_name = "additional-info"];
This will be required to be consistent with the yang model in tapi-gnmi-streaming.yang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf file added #619
Corrections to deal with config false issue #620