rpmsg_virtio: fix rpmsg_virtio_get_tx_payload_buffer() error #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If rpmsg_virtio_notify_wait() returns RPMSG_SUCCESS, we should not directly return NULL, but call rpmsg_virtio_get_tx_buffer to get the tx buffer again. Signed-off-by: Yongrong Wang <wangyongrong@xiaomi.com> Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
CV-Bowen
force-pushed
the
rpmsg-virtio-notify-wait-bug
branch
from
2f6eb4f to
87ad767
Compare
arnopo
approved these changes
Oct 21, 2024
Collaborator
|
@edmooring @tnmysh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If rpmsg_virtio_notify_wait() returns RPMSG_SUCCESS, we should not directly return NULL, but call rpmsg_virtio_get_tx_buffer to get the tx buffer again.
This is the new PR of #614, and you can find the detail discussions in #614