app-masking POC #643

Elelan · 2025-01-27T17:42:03Z

https://oadev.atlassian.net/browse/AOO-39

…feature/AOO-39-app-masking

added BaseDialog implementation with DialogTypes added reusable button composables

fastlane init

Proof Mode to Common Dialog Implementation

Mix Panel Implementation

Feature/Android 15 Edge-to-Edge + Official PickVisualMedia Migration Merging to next to continue edge to edge check for feature/storacha, created a backup branch called `next-11-aug-2025`.

…iption-fix fix: update internet archive description to clarify account types

…ublic server

…iption-fix fix: update upload description for internet archive to specify free public server

Updated text for AddFolderScreen and CreateNewFolderScreen

…-changes

…prefs_use_proofmode_description` string resource.

Bug fix/proofmode text changes

IA refactor to MVI from Redux CC License Setup Screen Compose Migration IA Detail Screen CC License Integration

… Detail Screen

… screens

SpaceList screen add btn size increased

…ds in crashlytics

removed space id arg from IALoginScreen, made IADetailScreen arg space_id as required

Feature/ia cc license

# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/net/opendasharchive/openarchive/features/settings/passcode/AppConfig.kt

Copilot

Pull Request Overview

This PR introduces app masking capabilities for the OpenArchive mobile application. The primary purpose is to allow users to disguise the app's appearance through alternate launcher icons and names, enhancing privacy and security for journalists and activists operating in sensitive environments.

Key Changes

Added app masking infrastructure with configurable launcher aliases (Save vs. Masked app icons)
Implemented comprehensive UI modernization migrating from View-based to Compose UI components
Enhanced passcode functionality with improved numeric keypad and haptic feedback

Reviewed Changes

Copilot reviewed 175 out of 314 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
app/src/main/res/drawable/*.xml	New vector drawable icons for masked app appearance and updated UI elements
app/src/main/java/.../app_masking/*	Core app masking utilities and settings activity for managing launcher aliases
app/src/main/java/.../passcode/*	Enhanced passcode system with new numeric keypad design and submit functionality
app/src/main/java/.../spaces/*	Modernized space setup screens using Compose UI
app/src/main/java/.../settings/*	Updated settings infrastructure with new license setup and configuration options

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-11T08:55:44Z

app/src/main/res/drawable/ic_info_outline.xml

@@ -0,0 +1,5 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android" android:height="24dp" android:tint="#000000" android:viewportHeight="24" android:viewportWidth="24" android:width="24dp">


The XML declaration is missing from this vector drawable. Consider adding <?xml version=\"1.0\" encoding=\"utf-8\"?> at the beginning for consistency with other drawable files.

Copilot · 2025-09-11T08:55:45Z

app/src/main/java/net/opendasharchive/openarchive/util/extensions/View.kt

+) = applyEdgeToEdgeInsets { insets ->
+
+    leftMargin = insets.left
+    rightMargin = insets.right


Missing documentation for the applySideInsets function. Consider adding a KDoc comment explaining its purpose and parameters.

Copilot · 2025-09-11T08:55:45Z

app/src/main/java/net/opendasharchive/openarchive/util/extensions/PackageManager.kt

        else {
            getPackageInfo(packageName, 0)
-        }.versionName
+        }.versionName ?: "unknown"


The fallback versionName ?: \"unknown\" duplicates the catch block return value. Consider extracting this to a constant to avoid magic strings.

Copilot · 2025-09-11T08:55:45Z

...ndasharchive/openarchive/features/settings/passcode/passcode_setup/PasscodeSetupViewModel.kt

+//        // Process passcode only when the required length is reached
+//        if (_uiState.value.passcode.length == config.passcodeLength) {
+//            _uiState.update { it.copy(isProcessing = true) }
+//            processPasscodeEntry()
+//        }


Dead code should be removed. These commented lines serve no purpose and reduce code readability.

Copilot · 2025-09-11T08:55:46Z

...ndasharchive/openarchive/features/settings/passcode/passcode_entry/PasscodeEntryViewModel.kt

    }

+    private fun onSubmit() {
+


The onSubmit method is empty but is referenced in the UI action. This could lead to unexpected behavior when users tap the submit button.

Suggested change

val state = uiState.value

if (!state.isProcessing && state.passcode.length == config.passcodeLength) {

_uiState.update { it.copy(isProcessing = true) }

checkPasscode()

}

github-advanced-security

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

app-masking POC

5e815a9

Elelan requested review from navodaSathsarani and prathieshna January 27, 2025 17:42

Elelan self-assigned this Jan 27, 2025

Elelan added 2 commits January 27, 2025 23:16

app-masking feature toggling

421a339

Merge remote-tracking branch 'origin/feature/raven-integration' into …

1a89a31

…feature/AOO-39-app-masking

Elelan marked this pull request as ready for review January 31, 2025 11:08

Elelan and others added 23 commits February 3, 2025 00:02

moved BaseFragment to core module

176993c

added BaseDialog implementation with DialogTypes added reusable button composables

BaseDialog and DialogConfig and builder pattern implemented completely

5c33f51

BaseDialog and DialogConfig and builder pattern implemented completely

0bb6477

next-branch missing changes

807fdd4

Commented the implementation

6331bc7

implementation

dee2c6e

refactor & rewrite wip

0cc4102

refactor-2

1caad71

refactor-3

58cba76

detekt setup

ff0c684

fastlane init

detekt fix

a228dee

commented out store data

4f3beb2

detekt check

34e2863

sarif file location updated

dd8ff76

fixes after first design review

3993f3c

removed kotlin-dotenv, downgraded gradle

e37a5f0

changed fonts, minor ui improvements according to figma design Save-3.0

2ecfb27

changed fonts, minor ui improvements according to figma design Save-3.0

90fe631

text font weight changes

bf667e5

enabled dweb flag

002f4a1

Merge pull request #646 from OpenArchive/feature/proofmode

8302cda

Proof Mode to Common Dialog Implementation

Merge branch 'feature/common-dialogs' into feature/mixpannel

305de61

Merge pull request #647 from OpenArchive/feature/mixpannel

2284890

Mix Panel Implementation

Elelan and others added 26 commits August 1, 2025 07:29

updated version to 4.0.2 and version code to 30014

ee91fff

AndroidManifest.xml minor code cleanup

5409f79

Merge pull request #701 from OpenArchive/feature/android-edge-to-edge

c03a6db

Feature/Android 15 Edge-to-Edge + Official PickVisualMedia Migration Merging to next to continue edge to edge check for feature/storacha, created a backup branch called `next-11-aug-2025`.

fix: update internet archive description to clarify account types

0fa02db

Merge pull request #702 from OpenArchive/bugFix/ia-login-header-descr…

4321b34

…iption-fix fix: update internet archive description to clarify account types

chore: increment versionCode to 30015

ef61d88

fix: update upload description for internet archive to specify free p…

347927f

…ublic server

Merge pull request #703 from OpenArchive/bugFix/ia-login-header-descr…

3777cbf

…iption-fix fix: update upload description for internet archive to specify free public server

Updated ProofMode descriptions and UI text

750795a

Updated text for AddFolderScreen and CreateNewFolderScreen

library upgrades and minor fixes

7db133a

Merge remote-tracking branch 'origin/next' into bugFix/proofmode-text…

17ad1f3

…-changes

The strings.xml file was modified to remove an extra space in the `…

432def7

…prefs_use_proofmode_description` string resource.

Merge pull request #706 from OpenArchive/bugFix/proofmode-text-changes

1b6aca4

Bug fix/proofmode text changes

Code cleanup = Dependency Upgrades

c722ca0

IA refactor to MVI from Redux CC License Setup Screen Compose Migration IA Detail Screen CC License Integration

SetupLicenseFragment now added for Internet Archive Onboarding and IA…

c06800e

… Detail Screen

adde new cc0 license to webdav and internet archive and setup license…

59b3cac

… screens

added add server btn to space list screen

2b539e3

Main activity side menu added Server text

7fe5657

SpaceList screen add btn size increased

setup passcode screen desc text change

96f2e81

library upgrades and minor code fix

1c3d4d0

added productFlavors to differentiate dev, staging vs production buil…

13b478c

…ds in crashlytics

ia screens arguments cleanup

3cc0390

removed space id arg from IALoginScreen, made IADetailScreen arg space_id as required

Merge pull request #707 from OpenArchive/feature/ia-cc-license

9ad7f42

Feature/ia cc license

upgraded ksp to 2.2.20-2.0.2

3add861

library upgrades

05538d0

Merge branch 'next' into feature/AOO-39-app-masking

6be2a2e

# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/net/opendasharchive/openarchive/features/settings/passcode/AppConfig.kt

Copilot AI review requested due to automatic review settings September 11, 2025 08:54

Copilot AI reviewed Sep 11, 2025

View reviewed changes

github-advanced-security bot found potential problems Sep 11, 2025

View reviewed changes

set default app in app masking

fccbf05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

app-masking POC #643

app-masking POC #643

Uh oh!

Elelan commented Jan 27, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 11, 2025

Uh oh!

Copilot AI Sep 11, 2025

Uh oh!

Copilot AI Sep 11, 2025

Uh oh!

Copilot AI Sep 11, 2025

Uh oh!

Copilot AI Sep 11, 2025

Uh oh!

github-advanced-security bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,5 @@
		<vector xmlns:android="http://schemas.android.com/apk/res/android" android:height="24dp" android:tint="#000000" android:viewportHeight="24" android:viewportWidth="24" android:width="24dp">

+        val state = uiState.value
+        if (!state.isProcessing && state.passcode.length == config.passcodeLength) {
+            _uiState.update { it.copy(isProcessing = true) }
+            checkPasscode()
+        }

Uh oh!

app-masking POC #643

Are you sure you want to change the base?

app-masking POC #643

Uh oh!

Conversation

Elelan commented Jan 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

github-advanced-security bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants