-
Couldn't load subscription status.
- Fork 3
Feat: GitHub Actions workflow for linting and tests #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tripledoublev
commented
May 24, 2025
- clippy fixes
- github action for linting and testing
- new test cleanup method
Update test cases to utilize the new cleanup function for stopping backends and ensure proper synchronization after operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR applies Clippy lint fixes, introduces a GitHub Actions workflow for linting and testing, and adds a shared test cleanup helper along with enhanced retry logic for test setup.
- Remove redundant module nesting and fix import paths for
get_backend - Adjust parameter passing for
create_veilid_cryptokey_from_base64and combine nested conditions - Refactor tests to add
wait_for_public_internet_readyandcleanup_test_resources, and update cleanup calls
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/server.rs | Flatten module structure by removing pub mod server |
| src/repos.rs | Fix imports for get_backend, remove & on calls, add unused anyhow::Result import |
| src/media.rs | Same import/path fixes as repos, consolidate conditionals, change handler return type |
| src/logging.rs | Use $crate in macro for proper hygiene |
| src/lib.rs | Extensive test refactoring: new helpers, assertions, cleanup |
| src/groups.rs | Fix imports, add explicit type annotation for Vec |
| README.md | Add API endpoint documentation |
| .github/workflows/lint_and_test.yml | New GitHub Actions workflow for Clippy and tests |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…dividual tests in parallel
Updated test names and paths for clarity, improved comments for better understanding, and ensured proper synchronization during group creation, file upload, and refresh operations. Enhanced assertions to verify expected outcomes after each refresh.