Skip to content

Conversation

@tripledoublev
Copy link
Contributor

  • clippy fixes
  • github action for linting and testing
  • new test cleanup method

@tripledoublev tripledoublev requested a review from Copilot May 24, 2025 01:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies Clippy lint fixes, introduces a GitHub Actions workflow for linting and testing, and adds a shared test cleanup helper along with enhanced retry logic for test setup.

  • Remove redundant module nesting and fix import paths for get_backend
  • Adjust parameter passing for create_veilid_cryptokey_from_base64 and combine nested conditions
  • Refactor tests to add wait_for_public_internet_ready and cleanup_test_resources, and update cleanup calls

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/server.rs Flatten module structure by removing pub mod server
src/repos.rs Fix imports for get_backend, remove & on calls, add unused anyhow::Result import
src/media.rs Same import/path fixes as repos, consolidate conditionals, change handler return type
src/logging.rs Use $crate in macro for proper hygiene
src/lib.rs Extensive test refactoring: new helpers, assertions, cleanup
src/groups.rs Fix imports, add explicit type annotation for Vec
README.md Add API endpoint documentation
.github/workflows/lint_and_test.yml New GitHub Actions workflow for Clippy and tests

@tripledoublev tripledoublev changed the title Fixes/clippy tests Adds GitHub Actions workflow for linting and tests May 24, 2025
@tripledoublev tripledoublev changed the title Adds GitHub Actions workflow for linting and tests Feat: GitHub Actions workflow for linting and tests May 24, 2025
tripledoublev and others added 5 commits May 23, 2025 21:30
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updated test names and paths for clarity, improved comments for better understanding, and ensured proper synchronization during group creation, file upload, and refresh operations. Enhanced assertions to verify expected outcomes after each refresh.
@tripledoublev tripledoublev merged commit 36bbfa5 into main May 25, 2025
11 checks passed
@tripledoublev tripledoublev deleted the fixes/clippy-tests branch May 25, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant