Support go lint#395
Open
zhugelianglongming wants to merge 6 commits intoOpenAtomFoundation:masterfrom
Open
Conversation
zhugelianglongming
force-pushed
the
dev-golint
branch
3 times, most recently
from
2b4eaf3 to
d7901c3
Compare
zhugelianglongming
force-pushed
the
dev-golint
branch
from
d7901c3 to
efe7eb4
Compare
zhugelianglongming
force-pushed
the
dev-golint
branch
from
cf2a119 to
5f59ca7
Compare
Collaborator
|
这个 pr 改的代码也太多了 |
Collaborator
Author
是的，但是没办法，开启报错之后，整个代码库都是错误。。。问题太多了。 代码库质量提升、集成自动校验肯定要经历这么一个过程，现在不改的话，以后也要改。除非要一直保留这些低质量代码。 这个代码库我改了非常久。 |
Collaborator
Author
|
@godeamon 有一些错误的处理，我把握不太好，辛苦你 reivew 下。 这个代码库中有太多的错误选择性忽略，不显示处理的话，太危险了。 |
Collaborator
|
如果一定要改的话，我建议你按照模块来慢慢改，一个是方便 review，另一个即使出问题了也好回滚。 |
zhugelianglongming
force-pushed
the
dev-golint
branch
from
7ffd979 to
19d3746
Compare
zhugelianglongming
force-pushed
the
dev-golint
branch
from
19d3746 to
a4755ee
Compare
Collaborator
Author
这个建议好，我看看有没有拆分的办法。 |
Collaborator
Author
|
@godeamon 话说之前部分 patch 操作处理 error，部分不处理有什么讲究或者考虑在里面吗？ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
#378
How tested