block streaming #89
Merged
block streaming #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecsavvy
commented
Nov 18, 2025
Comment on lines
+68
to
+75
| proxy_set_header Connection ""; | ||
|
|
||
| proxy_buffering off; | ||
| proxy_cache off; | ||
|
|
||
| proxy_read_timeout 1h; | ||
| proxy_send_timeout 1h; | ||
|
|
Member
Author
There was a problem hiding this comment.
nginx will buffer messages unless it's configured with buffering off
Member
Author
There was a problem hiding this comment.
probably worth putting this in the OAP docs for those running with nginx
rickyrombo
approved these changes
Nov 18, 2025
| 45, // 45: core.v1.CoreService.GetUploadByCID:output_type -> core.v1.GetUploadByCIDResponse | ||
| 23, // [23:46] is the sub-list for method output_type | ||
| 0, // [0:23] is the sub-list for method input_type | ||
| 23, // 23: core.v1.CoreService.StreamBlocks:input_type -> core.v1.StreamBlocksRequest |
Contributor
There was a problem hiding this comment.
This doesn't break existing stuff does it, having the ids bump like this?
Member
Author
There was a problem hiding this comment.
no, it maps grpc routes to their request and response types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a new StreamBlocks rpc that pushes full blocks to a client. example in the examples doc