Skip to content

refactor/Filter out empty URL prefixes and API standards #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonredfern merged 2 commits into from
Nov 19, 2025
Merged

refactor/Filter out empty URL prefixes and API standards #2630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9c35e0
refactor/Filter out empty URL prefixes and API standards in scanned A…
hongwei1 Nov 18, 2025
e1c5651
test/Filter out empty URL prefixes in scanned API versions list
hongwei1 Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion obp-api/src/main/scala/code/api/v4_0_0/APIMethods400.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11546,7 +11546,9 @@ trait APIMethods400 extends MdcLoggable {
implicit val ec = EndpointContext(Some(cc))
Future {
val versions: List[ScannedApiVersion] =
ApiVersion.allScannedApiVersion.asScala.toList
ApiVersion.allScannedApiVersion.asScala.toList.filter { version =>
version.urlPrefix.trim.nonEmpty
}
(
ListResult("scanned_api_versions", versions),
HttpCode.`200`(cc.callContext)
Expand Down
4 changes: 3 additions & 1 deletion obp-api/src/test/scala/code/api/v4_0_0/GetScannedApiVersionsTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ class GetScannedApiVersionsTest extends V400ServerSetup {

val listResult = response.body.extract[ListResult[List[ScannedApiVersion]]]
val responseApiVersions = listResult.results
val scannedApiVersions = ApiVersion.allScannedApiVersion.asScala.toList
val scannedApiVersions = ApiVersion.allScannedApiVersion.asScala.toList.filter { version =>
version.urlPrefix.trim.nonEmpty
}

responseApiVersions should equal(scannedApiVersions)

Expand Down