Skip to content

test/CreateUserTest to use constant for InvalidStrongPasswordFormat e… #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonredfern merged 1 commit into from
Nov 28, 2025
Merged

test/CreateUserTest to use constant for InvalidStrongPasswordFormat e… #2638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions obp-api/src/test/scala/code/api/v6_0_0/CreateUserTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package code.api.v6_0_0

import code.api.util.APIUtil.OAuth._
import code.api.util.ErrorMessages
import code.api.util.ErrorMessages.InvalidStrongPasswordFormat
import code.consumer.Consumers
import code.model.dataAccess.AuthUser
import com.openbankproject.commons.util.ApiVersion
Expand Down Expand Up @@ -282,7 +283,7 @@ class CreateUserTest extends V600ServerSetup {

And("The error should be InvalidStrongPasswordFormat")
val errorMessage = response.body.extract[ErrorMessageV600].message
errorMessage should include("Invalid Strong Password Format")
errorMessage should include(InvalidStrongPasswordFormat)
errorMessage should not include("OBP-10001")
}

Expand All @@ -304,7 +305,7 @@ class CreateUserTest extends V600ServerSetup {

And("The error should be InvalidStrongPasswordFormat")
val errorMessage = response.body.extract[ErrorMessageV600].message
errorMessage should include("Invalid Strong Password Format")
errorMessage should include(InvalidStrongPasswordFormat)
}

scenario("Fail to create user - password missing special character (10-16 chars)", ApiEndpointCreateUser, VersionOfApi) {
Expand All @@ -325,7 +326,7 @@ class CreateUserTest extends V600ServerSetup {

And("The error should be InvalidStrongPasswordFormat")
val errorMessage = response.body.extract[ErrorMessageV600].message
errorMessage should include("Invalid Strong Password Format")
errorMessage should include(InvalidStrongPasswordFormat)
}

scenario("Fail to create user - password missing digit (10-16 chars)", ApiEndpointCreateUser, VersionOfApi) {
Expand All @@ -346,7 +347,7 @@ class CreateUserTest extends V600ServerSetup {

And("The error should be InvalidStrongPasswordFormat")
val errorMessage = response.body.extract[ErrorMessageV600].message
errorMessage should include("Invalid Strong Password Format")
errorMessage should include(InvalidStrongPasswordFormat)
}

scenario("Fail to create user - password missing lowercase letter (10-16 chars)", ApiEndpointCreateUser, VersionOfApi) {
Expand All @@ -367,7 +368,7 @@ class CreateUserTest extends V600ServerSetup {

And("The error should be InvalidStrongPasswordFormat")
val errorMessage = response.body.extract[ErrorMessageV600].message
errorMessage should include("Invalid Strong Password Format")
errorMessage should include(InvalidStrongPasswordFormat)
}

scenario("Fail to create user - empty username", ApiEndpointCreateUser, VersionOfApi) {
Expand Down Expand Up @@ -431,7 +432,7 @@ class CreateUserTest extends V600ServerSetup {

And("The error should be InvalidStrongPasswordFormat")
val errorMessage = response.body.extract[ErrorMessageV600].message
errorMessage should include("Invalid Strong Password Format")
errorMessage should include(InvalidStrongPasswordFormat)
}

scenario("Successfully create user - password exactly 17 chars (no special requirements)", ApiEndpointCreateUser, VersionOfApi) {
Expand Down