fix: improve error handling in MetaDataHandler and SMDClient #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Contributor
|
This branch appears to have become stale. Could you rebase this onto the current |
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Member
Author
|
Merged main into branch and addressed merge conflict based on updates in this PR. |
synackd
approved these changes
Oct 1, 2025
Contributor
synackd
left a comment
synackd
left a comment
There was a problem hiding this comment.
This is a small change and it LGTM. I'm okay to merge this.
synackd
deleted the
67-bug-impersonating-non-existent-node-does-not-err
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves error handling and user feedback in the metadata handler and SMD client code. The changes focus on providing clearer error messages to clients and logging more informative errors for easier debugging.
Error handling and user feedback improvements:
MetaDataHandlerinmetadata_handlers.goto usehttp.Errorwith a descriptive message when failing to retrieve a node ID from an IP address, instead of just setting the status code.getSMDmethod inSMDclient.goto log and return a detailed error if the response status code is not OK, improving visibility into SMD request failures.