Skip to content

Conversation

@cjh1
Copy link
Member

@cjh1 cjh1 commented Oct 9, 2025

Pull Request Template

Thank you for your contribution! Please ensure the following before submitting:

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Description

Add support for showing/listing the power status of components

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

For more info, see Contributing Guidelines.

@cjh1
Copy link
Member Author

cjh1 commented Oct 9, 2025

@synackd Would you mine reviewing this one, I seem to have lost my powers to add a reviewer ...

@synackd synackd self-requested a review October 9, 2025 22:23
Copy link
Collaborator

@synackd synackd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Can you provide testing instructions? My PCS environment is wonky, but I'd like to test if I can.

cmd/pcs.go Outdated
Comment on lines 14 to 16
// xnames holds the list of xnames provided via command line flag
var xnames []string

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put a PCS prefix on this variable? Since this is in the cmd package, this would be a variable global to all commands.

On that note, we probably need to refactor the commands to be in their own packages to avoid this issue subsequently...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consequently, any package-level variables for PCS should have a prefix for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree each command should have is own package. I moved the definition of the variables into their respective files, no real need to reuse the same variable and this makes usage more clear.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you've added the command prefix (e.g. transitionXnames) but could we also prepend pcs to distinguish that this is part of the pcs transition command? E.g. pcsTransitionXnames

Signed-off-by: Chris Harris <cjh@lbl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants