Skip to content

[WIP] Nominations form updates#226

Open
chimon2000 wants to merge 3 commits intorelease_2018from
nominations_form_updates
Open

[WIP] Nominations form updates#226
chimon2000 wants to merge 3 commits intorelease_2018from
nominations_form_updates

Conversation

@chimon2000
Copy link
Copy Markdown
Collaborator

@chimon2000 chimon2000 commented Oct 27, 2018

  • Display a message to nominators if they enter a child that is older than fourteen years old. It will still allow the user to submit the form.
  • Move "reason for nomination" away from child; put on head of household section instead. Make a required field.
  • Change child age calculation to be based on their age on Christmas instead of the current date.
  • Add text around the wishlist text area to only enter toys that are under $50
  • Change "# in household" to "Number of kids being nominated"
  • When submitting the form, check whether the number of children actually entered does not match the number entered in the Number of kids field, alert the user of the discrepancy. We don't want to automatically calculate the number of children nominated; the field serves as a double-checking tool for the nominator.

<div>
{nominations &&
nominations.map((row, idx) => {
const dob = pathOr(new Date(), "dob", fields.value[idx]);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting a fields is not defined error

<Row>
{isTooOld && (
<Col xs={12}>
<Alert bsStyle="warning" key={name}>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name apparently makes the no-restricted-globals linter go mad 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants