This repository was archived by the owner on Dec 5, 2025. It is now read-only.
[client]: unify empty state handling#959
Merged
helene-nguyen merged 1 commit intomasterfrom Aug 18, 2025
Conversation
c91d3dc to
067d157
Compare
067d157 to
7cc1d6e
Compare
helene-nguyen
approved these changes
Aug 18, 2025
Member
helene-nguyen
left a comment
There was a problem hiding this comment.
@pdamoune Thank you for this fix !
Tested and all good for me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Original issue :
In order to handle the reset of the state in the UI for stream connectors, this conditions had been implemented in the past :
38fc5c4#diff-d5f76d595ba569b42f34c9cbf943833f0e132010315ed4680b7966f2ee961868R418-R422
However, no else condition was added here :
38fc5c4#diff-d5f76d595ba569b42f34c9cbf943833f0e132010315ed4680b7966f2ee961868R428-R429
Also, an error in the code had been fixed by this code :
2efa061#diff-d5f76d595ba569b42f34c9cbf943833f0e132010315ed4680b7966f2ee961868L519
And wasn't changed on L786
This Fix handle the NoneType error and fix the exit_event.set()
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...