Open
Conversation
|
This pull request introduces 2 alerts when merging 2d0bb90 into b6df22d - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging e22c132 into 3094dcc - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging a32c8c5 into 3094dcc - view on LGTM.com new alerts:
|
a32c8c5 to
f7c9f36
Compare
|
This pull request introduces 1 alert when merging f7c9f36 into 3094dcc - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 7c17601 into 3094dcc - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 2871a5f into 3094dcc - view on LGTM.com new alerts:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this MR, we demonstrate the usage of Google Sheets as an alternative registry storage, instead of the static
registry.json.Key changes:
Since an API key is needed to access the Google Sheets data,
OpenCertsVerificationManagerOptionsnow extendsVerificationManagerOptionsin OpenAttestation to includegoogleApiKey, so that it can be used in theregistryVerifier.verify()method.Added
GoogleSpreadsheetValuesto follow thespreadsheets.valuesAPITemporary changes (will be reverted):
distfiles so that the feature branch onopencerts-websitescan build properly