This repository was archived by the owner on May 3, 2023. It is now read-only.
Merged
Conversation
pablothedude
force-pushed
the
featuer/add-translations-nl
branch
from
ff2d658 to
cfef798
Compare
pablothedude
force-pushed
the
featuer/add-translations-nl
branch
3 times, most recently
from
cdb87f6 to
7d35a0b
Compare
MKodde
suggested changes
Mar 11, 2021
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * Copyright 2010 SURFnet B.V. |
Contributor
There was a problem hiding this comment.
Please set this to either the year this product was written, or use the current year. Also applies for the associated test
translations/messages.nl.yaml
Outdated
| @@ -0,0 +1,7 @@ | |||
| readid.authorization.title: 'Identiteitscontrole' | |||
| readid.authorization.text: 'Onherstelbare error' | |||
Contributor
There was a problem hiding this comment.
Maybe 'fout' is more mainstream (and iirc is used in the other openconext applications)
| use Symfony\Component\HttpKernel\Event\RequestEvent; | ||
| use Symfony\Component\HttpKernel\KernelEvents; | ||
|
|
||
| class LocaleSubscriber implements EventSubscriberInterface |
Contributor
There was a problem hiding this comment.
Code looks familiar, is this copied from the StepupBundle?
Also make the authentication page translatable
pablothedude
force-pushed
the
featuer/add-translations-nl
branch
from
7d35a0b to
bf8fff4
Compare
MKodde
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/176891048