Skip to content

ci(release): drop macos-x64 from release matrix #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sun-sunshine06 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −16
Open

ci(release): drop macos-x64 from release matrix #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,25 +126,16 @@ jobs:
strategy:
fail-fast: false
matrix:
# macOS is split into two native-arch runners. Cross-building both
# DMGs on a single arm64 host (what we used to do) shipped the host
# arch's native module inside the x64 DMG because electron-builder
# does not re-stage our per-arch better-sqlite3 prebuilds per target
# arch — see #176 (dlopen fails on Intel Macs). Using a native-arch
# runner per DMG guarantees `pnpm install` stages the right
# better_sqlite3.node* files for each target and keeps the legacy
# alias (better_sqlite3.node-electron.node) matching the DMG arch.
# macOS packaging is temporarily limited to Apple Silicon runners.
# The Intel macOS queue is chronically unavailable on our current
# Actions capacity, which blocks the whole release pipeline because
# `publish` waits for the full `build` matrix to finish.
include:
- os: macos-latest # arm64 Apple Silicon runner
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Major] This matrix now removes the only macos-x64 release artifact. The repo still advertises Intel macOS support in README.md:151, README.zh-CN.md:149, website/quickstart.md:33, and website/faq.md:86, so this is a release-support regression rather than just a CI optimization.

Suggested fix:

build-macos-x64:
  name: Build (macos-x64, best-effort)
  needs: [gate, changelog]
  runs-on: macos-13
  continue-on-error: true
  steps:
    - run: pnpm --filter @open-codesign/desktop exec electron-vite build
    - run: pnpm --filter @open-codesign/desktop exec electron-builder --mac --x64 --publish never

label: macos-arm64
mac_arch: arm64
artifact_name: installer-macos-arm64
artifact_glob: 'apps/desktop/release/*.dmg'
- os: macos-13 # Intel x64 runner (macos-latest is arm64)
label: macos-x64
mac_arch: x64
artifact_name: installer-macos-x64
artifact_glob: 'apps/desktop/release/*.dmg'
- os: windows-latest
label: windows-latest
artifact_name: installer-windows-latest
Expand Down Expand Up @@ -190,9 +181,8 @@ jobs:
# Package the Electron app.
# CSC_IDENTITY_AUTO_DISCOVERY=false: skip ad-hoc Mac signing prompt.
# WIN_CSC_LINK / WIN_CSC_KEY_PASSWORD: intentionally unset (no cert in v0.1).
# On macOS we force-pin the target arch to the runner's host arch
# (--arm64 on macos-latest, --x64 on macos-13) so each DMG is packaged
# natively instead of cross-built (see matrix comment + #176).
# On macOS we force-pin the target arch to the Apple Silicon runner's
# host arch so the DMG is packaged natively instead of cross-built.
- name: Package desktop (non-mac)
if: runner.os != 'macOS'
env:
Expand Down
Loading