Compatibility with Forge+Bukkit environment #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niko-sk2x
requested changes
Jan 5, 2025
Member
Niko-sk2x
left a comment
Niko-sk2x
left a comment
There was a problem hiding this comment.
While I'm overall fine with bukkit compat the current provided implementation isn't very maintainable.
I also have some concerns about bukkit API license being GPL, while CC being MIT
src/main/java/io/github/opencubicchunks/cubicchunks/core/util/PlatformCompatUtils.java
Outdated
Show resolved
Hide resolved
...o/github/opencubicchunks/cubicchunks/core/asm/mixin/core/common/MixinWorldServer_Bukkit.java
Outdated
Show resolved
Hide resolved
...hub/opencubicchunks/cubicchunks/core/asm/mixin/core/common/MixinPlayerList_Bukkit_Sided.java
Outdated
Show resolved
Hide resolved
...n/java/io/github/opencubicchunks/cubicchunks/core/asm/mixin/core/common/MixinPlayerList.java
Outdated
Show resolved
Hide resolved
.../java/io/github/opencubicchunks/cubicchunks/core/asm/mixin/core/common/MixinChunk_Cubes.java
Outdated
Show resolved
Hide resolved
...java/io/github/opencubicchunks/cubicchunks/core/asm/mixin/core/common/MixinChunk_Column.java
Show resolved
Hide resolved
src/main/java/io/github/opencubicchunks/cubicchunks/core/asm/coremod/CubicChunksCoreMod.java
Outdated
Show resolved
Hide resolved
Member
|
This also needs vanilla client compatibility tested. |
Contributor
Author
|
Tested on Vanilla Forge client and hybrid servers, works fine. |
Niko-sk2x
reviewed
Jan 5, 2025
src/main/java/io/github/opencubicchunks/cubicchunks/core/util/CompatHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/opencubicchunks/cubicchunks/core/util/CompatHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/opencubicchunks/cubicchunks/core/util/CompatHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/opencubicchunks/cubicchunks/core/util/ReflectionUtil.java
Outdated
Show resolved
Hide resolved
Niko-sk2x
reviewed
Jan 6, 2025
Member
Niko-sk2x
left a comment
Niko-sk2x
left a comment
There was a problem hiding this comment.
One last minor thing - we generally prefer to explain something like this that isn't entirely obvious in comments.
My last remaining concern is license, but other than that looks good. I'm going to accept it once this one comment is added, if licensing ever becomes an issue bukkit support can still be removed.
src/main/java/io/github/opencubicchunks/cubicchunks/core/asm/mixin/core/common/MixinWorld.java
Show resolved
Hide resolved
Niko-sk2x
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes CubicChunks able to run on Forge+Bukkit server environment while keeping normal Forge compatibility.
Changes