Skip to content

chore: remove dead invite code fallback#245

Merged
shuxueshuxue merged 1 commit intodevfrom
code-killer-phase-32
Apr 7, 2026
Merged

chore: remove dead invite code fallback#245
shuxueshuxue merged 1 commit intodevfrom
code-killer-phase-32

Conversation

@shuxueshuxue
Copy link
Copy Markdown
Collaborator

Summary

  • remove the dead Array.isArray compatibility branch from fetchInviteCodes()
  • prune the now-unused list_all* fake-repo surface from test_invite_codes_router.py
  • keep the invite-code helper's real error-contract tests (500 prefix mapping, HTTPException passthrough, revoke -> 404)

Residual Risk

  • if some stale backend outside this repo still returns a bare invite-code array instead of { "codes": [...] }, that unsupported version skew would now fail on the frontend

Test Plan

  • uv run ruff check tests/Integration/test_invite_codes_router.py
  • uv run ruff format --check tests/Integration/test_invite_codes_router.py
  • ALL_PROXY= HTTPS_PROXY= HTTP_PROXY= all_proxy= https_proxy= http_proxy= uv run pytest tests/Integration/test_invite_codes_router.py tests/Integration/test_thread_files_channel_shell.py tests/Integration/test_settings_local_path_shell.py -q
  • cd frontend/app && npm run build

@shuxueshuxue shuxueshuxue merged commit fff80a5 into dev Apr 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant