Skip to content

Remove duplicated code in Mastr.download() #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianK13 merged 2 commits into from
Apr 2, 2026
Merged

Remove duplicated code in Mastr.download() #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e92130
Remove duplicated code #726
FlorianK13 Mar 26, 2026
09e3485
Update changelog #726
FlorianK13 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ and the versioning aims to respect [Semantic Versioning](http://semver.org/spec/
[#722](https://github.com/OpenEnergyPlatform/open-MaStR/pull/722)

### Removed
- Remove duplicated code in Mastr.download
[#727](https://github.com/OpenEnergyPlatform/open-MaStR/pull/727)

## [v0.16.1] Hotfix - 2025-12-17

Expand Down
9 changes: 0 additions & 9 deletions open_mastr/mastr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,15 +239,6 @@ def download(
"or configure your own number of processes via os.environ['NUMBER_OF_PROCESSES'] = your_number\n"
)

delete_zip_file_if_corrupted(zipped_xml_file_path)
delete_xml_files_not_from_given_date(zipped_xml_file_path, xml_folder_path)

print(
"\nWould you like to speed up the creation of your MaStR database?\n"
"Try our new parallelized processing by setting os.environ['USE_RECOMMENDED_NUMBER_OF_PROCESSES'] = True "
"or configure your own number of processes via os.environ['NUMBER_OF_PROCESSES'] = your_number\n"
)

write_mastr_xml_to_database(
engine=self.engine,
zipped_xml_file_path=zipped_xml_file_path,
Expand Down
Loading