Zero fill specific date strings #719

[pt-kkraemer]

Summary of the discussion

When date-typos occur in years (0219 instead of 2019) and we do not pad these values when converting to string, the pandas pd.read_sql call cannot handle three-digit-years, it is simply not a correct isoformat, see #719.

Type of change (CHANGELOG.md)

Updated

• Added .str.zfill(10) in cast_date_columns_to_string

Workflow checklist

• I have not yet checked other possible occurences in the code where we handle datetimes
• I have to workaround the fact that None.str.zfill(10) does not work because 'NoneType' object has no attribute 'str'
  • Fixed here

Automation

Closes #719

PR-Assignee

• 🐙 Follow the workflow in CONTRIBUTING.md
• 📝 Update the CHANGELOG.md
• 📙 Update the documentation

Reviewer

• 🐙 Follow the Reviewer Guidelines
• 🐙 Provided feedback and show sufficient appreciation for the work done

[FlorianK13]

@pt-kkraemer did you run the tests locally? Because of the problem described in #729 the tests do not trigger, but it is also annoying to always commit some super small changes just to trigger the tests.

[pt-kkraemer]

Output from pytest tests/ -v

and here the outputs from the five failed tests:

• The first three fails are expected I guess?
• I will be investigating the test_Mastr_translate fail, it seems to be a windows specific problem with the local DB connection:[ERROR] An error occurred while renaming database: [WinError 32] Der Prozess kann nicht auf die Datei zugreifen, da sie von einem anderen Prozess verwendet wird: 'C:\\Users\\kkrae\\.open-MaStR\\data\\sqlite\\mastr-test.db' -> 'C:\\Users\\kkrae\\.open-MaStR\\data\\sqlite\\mastr-test-translated.db'
• And the last error stems from looking for a .xml that is not downloaded anyway, should I rewrite the test?

[FlorianK13]

No, we will need to update tests anyway. Can you delete/move everything from .open-mastr/data and then run the tests? At least the missing xml file test should not fail then anymore.

[pt-kkraemer]

Yes:

[FlorianK13]

@pt-kkraemer lgtm - you can merge if you want.