Skip to content

Switch from pd.read_xml to lxml.etree.fromstring #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pt-kkraemer wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Switch from pd.read_xml to lxml.etree.fromstring #735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions open_mastr/xml_download/utils_write_to_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,10 +325,13 @@ def correct_ordering_of_filelist(files_list: list) -> list:
def read_xml_file(f: ZipFile, file_name: str) -> pd.DataFrame:
"""Read the xml file from the zip file and return it as a DataFrame."""
with f.open(file_name) as xml_file:
try:
return pd.read_xml(xml_file, encoding="UTF-16", parser="etree")
except lxml.etree.XMLSyntaxError as error:
return handle_xml_syntax_error(xml_file.read().decode("utf-16"), error)
raw = xml_file.read()
try:
root = lxml.etree.fromstring(raw)
except lxml.etree.XMLSyntaxError as error:
return handle_xml_syntax_error(raw.decode("utf-16"), error)
records = [{child.tag: child.text for child in row} for row in root]
return pd.DataFrame(records)


def change_column_names_to_orm_format(
Expand Down