Skip to content

Some updates based on work with manus 128#47

Open
isoAdvector wants to merge 3 commits intoOpenFOAM-Journal:masterfrom
isoAdvector:master
Open

Some updates based on work with manus 128#47
isoAdvector wants to merge 3 commits intoOpenFOAM-Journal:masterfrom
isoAdvector:master

Conversation

@isoAdvector
Copy link
Copy Markdown

No description provided.

Needed to handle Icelandic letters
Enclosed lstlisting in minipage to avoid code snippet cut across several pages. Not ideal solution. Could cause vertical alignement troubles in papers with many long listings.
Copy link
Copy Markdown
Collaborator

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I guess I am maybe the right person to give some review here. The missing description triggered some questions.

Generally, one PR per suggestion would be better, as you originally had it.

Please also merge from master, I pushed some changes to the CI.

Copy link
Copy Markdown
Collaborator

@MakisH MakisH Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case did you need to provide this as an additional file?
By the way, there seems to be some recent renaming of files in TeX Live. Does maybe setting

- \bibliographystyle{IEEEtran}
+ \bibliographystyle{ieeetran}

work for you? In any case, what you suggest might be the more portable way.

Edit: Related to #43

\usepackage{finiteVolumeNotation}

% Other packages and commands
\usepackage[T1]{fontenc}
Copy link
Copy Markdown
Collaborator

@MakisH MakisH Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Edit: Seems to be related to #45 (comment) and the IEEEtran bib style.

Herein, $\Q=\Q(\xt)$ is an arbitrary general intensive physical quantity, e.g., a fluid property (scalar or tensor of any rank). Thus, \autoref{eq:genTransEq} is often referred to as a generic transport equation.

\OF (Open Field Operation And Manipulation) is a flexible and mature C++ Class Library for Computational Continuum Mechanics (CCM) and Multiphysics. Its Object-Oriented-Programming (OOP) paradigm enables to \emph{mimic data types and basic operations} of CCM using top-level syntax as close as possible to the conventional mathematical notation \emph{for tensors and partial differential equations}:
\noindent\begin{minipage}
Copy link
Copy Markdown
Collaborator

@MakisH MakisH Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wrapping the lstlisting in a minipage? This is generally not necessary.

Edit: Seems to be related to #46 and #44, aiming to not cut listings between pages. I would argue that this might not be a good idea for long listings.

Edit: I see the point, makes sense.

@MakisH
Copy link
Copy Markdown
Collaborator

MakisH commented Apr 10, 2025

I found the related issues and individual PRs and edited by comments to link to them. I think this is generally a good idea, but please merge from master, to be able to run the CI and check the build artifact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants