Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ac0cb1b to
d337809
Compare
This reverts commit d337809.
IAlibay
left a comment
There was a problem hiding this comment.
This looks good to me, but Mike is really the person "in the know" for how/why we did things with "install_from_url".
| " import condacolab\n", | ||
| " import locale\n", | ||
| " locale.getpreferredencoding = lambda: \"UTF-8\"\n", | ||
| " !mamba -q install openfe\n", |
There was a problem hiding this comment.
This makes sense to me, but @mikemhenry should really be the approver here.
|
I've commented on the issue but the tl;dr is that I think things are more likely to break with the env than with the colab infra |
|
Also I think we can improve the locale swiches/hacks with this: from googlecolab/colabtools#3409 (comment) (I can't remember if this notebook is the one where I have switch back and forth) |
|
closing this issue, going to bump our single file installers to python 3.11 instead. |
resolves #193