Skip to content

switch install to mamba#194

Closed
atravitz wants to merge 5 commits intomainfrom
fix_colab_installation
Closed

switch install to mamba#194
atravitz wants to merge 5 commits intomainfrom
fix_colab_installation

Conversation

@atravitz
Copy link
Contributor

resolves #193

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch OpenFreeEnergy/ExampleNotebooks/fix_colab_installation

@atravitz atravitz force-pushed the fix_colab_installation branch from ac0cb1b to d337809 Compare February 24, 2025 18:46
@atravitz atravitz requested a review from mikemhenry February 24, 2025 18:52
@atravitz atravitz requested a review from IAlibay February 25, 2025 19:12
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but Mike is really the person "in the know" for how/why we did things with "install_from_url".

" import condacolab\n",
" import locale\n",
" locale.getpreferredencoding = lambda: \"UTF-8\"\n",
" !mamba -q install openfe\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, but @mikemhenry should really be the approver here.

@mikemhenry
Copy link
Contributor

I've commented on the issue but the tl;dr is that I think things are more likely to break with the env than with the colab infra

@mikemhenry
Copy link
Contributor

Also I think we can improve the locale swiches/hacks with this:

def return_utf_8(input=None):
    return "UTF-8"
locale.getpreferredencoding = return_utf_8

from googlecolab/colabtools#3409 (comment) (I can't remember if this notebook is the one where I have switch back and forth)

@atravitz
Copy link
Contributor Author

closing this issue, going to bump our single file installers to python 3.11 instead.

@atravitz atravitz closed this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

colab notebook url install failing

3 participants