Adapt default charge change score to allow for charge changing transformations

[hannahbaumann]

Only adapt this in gufe bindings to not affect main Lomap behaviour.

• Check if docs have to be updated
  ---> The scorers are not part of the API documentation?!

[atravitz]

This should have a corresponding test and news entry, otherwise looks good!

[IAlibay]

Hold on my end - I want to double check the other ways to use Lomap networks aren't being affected.

[hannahbaumann]

@atravitz I changed a test that was checking the connection of networks when using a charge score of 0.1 to test that with the new default (charge score of 0.1) we are getting connected networks. Or should I also explicitly test for the value of the score?
I also added a news item.

[atravitz]

The check you have is great, but I would also explicitly check that the correct value is being assigned, since we'd want tests to break if the actual value is getting mutated somewhere and turning out to be not 0.1.

Other than that, this looks good to me!

[IAlibay]

Sorry about the delay, took me a while to realise all of scorers.py is a duplicate of what's in the MCS file (we should fix that later).

[hannahbaumann]

Thanks! @atravitz I added a test for the new default charge change score!

[atravitz]

one more thing - does this need to be reflected in the docs somewhere?

[hannahbaumann]

@atravitz : I added the default_lomap_score function to the API docs built, so the updated default should be visible there. Docs are however currently failing for this repo.

[atravitz]

thanks @hannahbaumann - the docs are building correctly for me locally, so I consider this a readthedocs headache that I will address in a follow-up (likely here).

[atravitz]

docs are fixed!