Open
Conversation
Member
dotsdl
commented
Dec 10, 2025
dotsdl
commented
- Apply similar enforcement to ComputeServiceID form as in ComputeManagerID
- Sticking to looser construction of ComputeServiceID for now
- Black
- Adds ComputeServiceID form enforcement
…erID As a way to reduce the variability of ComputeServiceIDs, we propose adopting a similar approach to how these IDs are formed as in ComputeManagerID.
dotsdl
changed the title
dotsdl
added a commit
that referenced
this pull request
Dec 10, 2025
dotsdl
added a commit
that referenced
this pull request
Dec 11, 2025
* Apply similar enforcement to ComputeServiceID form as in ComputeManagerID As a way to reduce the variability of ComputeServiceIDs, we propose adopting a similar approach to how these IDs are formed as in ComputeManagerID. * Sticking to looser construction of ComputeServiceID for now * Black * Test fixes due to ComputeManager naming convention changes * Black * Remove commented code from ComputeServiceID * Black * Allow ":" in ComputeManagerID in line with upcoming changes in #467 * Added colon to ValueError message * Test fix from changes * Fix to enforcement of compute_manager_id name in compute API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.