Skip to content

Address issue #222#477

Open
dotsdl wants to merge 2 commits intomainfrom
claude/address-issue-222-EnCIf
Open

Address issue #222#477
dotsdl wants to merge 2 commits intomainfrom
claude/address-issue-222-EnCIf

Conversation

@dotsdl
Copy link
Member

@dotsdl dotsdl commented Jan 9, 2026

This commit introduces a new scopes_exclude configuration parameter for compute services, addressing issue #222.

Changes:

  • Added scopes_exclude field to ComputeServiceSettings with validation
  • Updated ComputeService to initialize and pass scopes_exclude to client
  • Updated ComputeClient.claim_tasks() to accept and transmit scopes_exclude
  • Updated compute API /claim endpoint to filter taskhubs based on excluded scopes
  • Filtering uses Scope.is_superset() to exclude taskhubs matching excluded scopes

The scopes_exclude option is applied after scopes as a filter, allowing users to specify broad scopes while excluding specific subset scopes from task claiming.

Fixes #222

claude added 2 commits January 9, 2026 21:24
This commit introduces a new `scopes_exclude` configuration parameter
for compute services, addressing issue #222.

Changes:
- Added `scopes_exclude` field to ComputeServiceSettings with validation
- Updated ComputeService to initialize and pass scopes_exclude to client
- Updated ComputeClient.claim_tasks() to accept and transmit scopes_exclude
- Updated compute API /claim endpoint to filter taskhubs based on excluded scopes
- Filtering uses Scope.is_superset() to exclude taskhubs matching excluded scopes

The scopes_exclude option is applied after scopes as a filter, allowing users
to specify broad scopes while excluding specific subset scopes from task claiming.

Fixes #222
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 23.07692% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.42%. Comparing base (42ebace) to head (5d45baf).

Files with missing lines Patch % Lines
alchemiscale/compute/api.py 0.00% 11 Missing ⚠️
alchemiscale/compute/settings.py 33.33% 8 Missing ⚠️
alchemiscale/compute/service.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   78.72%   78.42%   -0.30%     
==========================================
  Files          29       29              
  Lines        4799     4825      +26     
==========================================
+ Hits         3778     3784       +6     
- Misses       1021     1041      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add scopes-exclude config option for compute services

2 participants