Conversation
This commit introduces a new `scopes_exclude` configuration parameter for compute services, addressing issue #222. Changes: - Added `scopes_exclude` field to ComputeServiceSettings with validation - Updated ComputeService to initialize and pass scopes_exclude to client - Updated ComputeClient.claim_tasks() to accept and transmit scopes_exclude - Updated compute API /claim endpoint to filter taskhubs based on excluded scopes - Filtering uses Scope.is_superset() to exclude taskhubs matching excluded scopes The scopes_exclude option is applied after scopes as a filter, allowing users to specify broad scopes while excluding specific subset scopes from task claiming. Fixes #222
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
==========================================
- Coverage 78.72% 78.42% -0.30%
==========================================
Files 29 29
Lines 4799 4825 +26
==========================================
+ Hits 3778 3784 +6
- Misses 1021 1041 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new
scopes_excludeconfiguration parameter for compute services, addressing issue #222.Changes:
scopes_excludefield to ComputeServiceSettings with validationThe scopes_exclude option is applied after scopes as a filter, allowing users to specify broad scopes while excluding specific subset scopes from task claiming.
Fixes #222