Open
Conversation
This commit implements the changes requested in issue #195 to improve error handling and tracking in the alchemiscale system. Changes: 1. Added optional 'reason' field to Task model to store error tracebacks or user-provided reasons for state changes 2. Updated statestore methods (set_task_error, set_task_invalid, set_task_deleted) to accept and store the reason parameter 3. Added error handling around ProtocolDAG creation in compute service: - Catches exceptions during transformation.create() - Sets task to error status with exception traceback as reason - Prevents compute service crashes 4. Added new API endpoint POST /tasks/{task_scoped_key}/error to set task error status with reason for creation-time failures 5. Added corresponding client method set_task_error() 6. Updated existing set_task_result endpoint to pass failure reasons when setting tasks to error after execution failures Closes #195
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements the changes requested in issue #195 to improve error handling and tracking in the alchemiscale system.
Changes:
Added optional 'reason' field to Task model to store error tracebacks or user-provided reasons for state changes
Updated statestore methods (set_task_error, set_task_invalid, set_task_deleted) to accept and store the reason parameter
Added error handling around ProtocolDAG creation in compute service:
Added new API endpoint POST /tasks/{task_scoped_key}/error to set task error status with reason for creation-time failures
Added corresponding client method set_task_error()
Updated existing set_task_result endpoint to pass failure reasons when setting tasks to error after execution failures
Closes #195