Skip to content

[WIP] Issue 109 base estimator class#115

Open
richardjgowers wants to merge 4 commits intomainfrom
issue_109_base_estimator_class
Open

[WIP] Issue 109 base estimator class#115
richardjgowers wants to merge 4 commits intomainfrom
issue_109_base_estimator_class

Conversation

@richardjgowers
Copy link
Contributor

Description

Provide a brief description of the PR's purpose here.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • TODO 1

Questions

  • Question1

Status

  • Ready to go

@pep8speaks
Copy link

pep8speaks commented Dec 11, 2023

Hello @richardjgowers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 20:1: E402 module level import not at top of file

Line 1:32: W292 no newline at end of file

Line 83:13: E303 too many blank lines (2)
Line 145:17: E124 closing bracket does not match visual indentation
Line 154:13: E741 ambiguous variable name 'l'
Line 155:29: E713 test for membership should be 'not in'
Line 169:16: E713 test for membership should be 'not in'
Line 188:9: E122 continuation line missing indentation or outdented
Line 190:9: E122 continuation line missing indentation or outdented

Comment last updated at 2023-12-14 14:14:36 UTC

@codecov
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #115 (c7c77e8) into main (201c17c) will increase coverage by 0.00%.
The diff coverage is 87.50%.

Additional details and impacted files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants