Open
Conversation
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 96.25% 96.62% +0.37%
==========================================
Files 18 20 +2
Lines 1467 1629 +162
==========================================
+ Hits 1412 1574 +162
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ersions # Conflicts: # cinnabar/tests/test_conversion.py
IAlibay
reviewed
Feb 16, 2026
Member
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
I'll let @hannahbaumann do the approval here - from a quick glance this looks great!
| raise ValueError(f"Unknown final_type: {final_type}. Must be one of: {', '.join(valid_types)}") | ||
|
|
||
| # store the conversion functions by (original_type, final_type) in a dictionary for easy lookup | ||
| converters = { |
| original_type: OBSERVABLE_TYPES, | ||
| final_type: OBSERVABLE_TYPES, | ||
| uncertainty: None | unit.Quantity = None, | ||
| temperature: unit.Quantity = 300.0 * unit.kelvin, |
Member
There was a problem hiding this comment.
Within openfe we default to 298.15, do we want to use that here or are we better off with the idea that a lot of the experimental measurements are at 300?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #151 by adding an affinity unit conversion function extracted from the PLB. Plan to add tutorials and docs in another PR.
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Checklist
newsentry for new features, bug fixes, or other user facing changes.Status
Tips
Since this will create a commit, it is best to make this comment when you are finished with your work.