Allow for computations where both directions of an edge have been calculated

[hannahbrucemacdonald]

Description

form_edge_matrix now checks if the backwards edge has been run, and if so, uses a combination rule to use both to generate the matrix.

the matrix returned will be fully symmetric/antisymmetric

Todos

Notable points that this PR has either accomplished or will accomplish.

• TODO 1

Questions

• Question1

Status

• Ready to go

[jchodera]

Awesome!

But shouldn't it combine these in an uncertainty-aware manner? The optimal way to combine two independent measurements A1, A2 with standard errors dA1, dA2 is via the MLE:

A = w1 * A1 + w2*A2
dA = sqrt(1 / (dA1**(-2) + dA2**(-2))
w1 = dA1**(-2) / (dA1**(-2) + dA2**(-2))
w2 = dA2**(-2) / (dA1**(-2) + dA2**(-2))

The measurement with the smallest uncertainty will have greater weight.

[lgtm-com]

This pull request introduces 1 alert and fixes 2 when merging 888fff3 into 18e28c4 - view on LGTM.com

new alerts:

• 1 for Syntax error

fixed alerts:

• 2 for Unused local variable