Base classes and example for client-side code#10
Open
dwhswenson wants to merge 13 commits intomainfrom
Open
Conversation
this is a side-effect of cherry picking a change into here
…-side-baseclasses
Problem with second superclass for typing with NamedTuple
dwhswenson
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 3.52% 75.35% +71.82%
==========================================
Files 4 8 +4
Lines 85 211 +126
==========================================
+ Hits 3 159 +156
+ Misses 82 52 -30
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…xorcist into client-side-baseclasses
dwhswenson
requested review from
IAlibay,
RiesBen,
mikemhenry and
richardjgowers
Member
Author
|
Note: will need to revert changes in 1cbf299 here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4. Resolves #5. Resolves #6.
This includes the example code for a client that just gets a float result from each task, stores some data with that result and some metadata in a JSON file, and stores the tasks and how to run them as a pickle dump. I'm not sure where to actually keep that example code; maybe it should move under
tests? My thought is that it'll be useful to us in writing tests (or even demos), but we probably don't want "real" people to be importing it.