TaskStatusDB: Test for _task_row_update_statement#25
Draft
dwhswenson wants to merge 4 commits intomainfrom
Draft
TaskStatusDB: Test for _task_row_update_statement#25dwhswenson wants to merge 4 commits intomainfrom
_task_row_update_statement#25dwhswenson wants to merge 4 commits intomainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 86.62% 91.63% +5.00%
==========================================
Files 5 5
Lines 344 526 +182
==========================================
+ Hits 298 482 +184
+ Misses 46 44 -2
☔ View full report in Codecov by Sentry. |
Member
Author
|
Putting this on hold (as draft) because I think it might have conflicts with #31. Part of this PR involves actually testing the SQL that gets emitted; this was intended as a way to give a clear picture of what is happening behind the scenes. But the SQL that gets emitted might be dialect-specific. I'll come back to finish this after #31 is merged in (prefer to get that in and have the conflict block here than the other way around). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I promised more detailed unit tests for this function in #21. Here they are.