Skip to content

Adding a generic atom mapping scorer#306

Closed
RiesBen wants to merge 16 commits intomainfrom
adding_atom_mapping_scorer
Closed

Adding a generic atom mapping scorer#306
RiesBen wants to merge 16 commits intomainfrom
adding_atom_mapping_scorer

Conversation

@RiesBen
Copy link
Contributor

@RiesBen RiesBen commented Apr 17, 2024

this is a generic interface for all openFE scorers.

Todo:

  • define Interface
  • tests
  • tokenizable
  • User stories
  • Find Update places (LOMAP, Ruler, OpenFE-Setup, Example Scripts and Notebooks)

@pep8speaks
Copy link

pep8speaks commented Apr 17, 2024

Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 21:80: E501 line too long (90 > 79 characters)

Line 8:1: E302 expected 2 blank lines, found 1
Line 18:50: E231 missing whitespace after ':'
Line 18:80: E501 line too long (85 > 79 characters)
Line 19:80: E501 line too long (97 > 79 characters)
Line 29:22: E222 multiple spaces after operator
Line 32:5: E303 too many blank lines (2)
Line 32:66: E225 missing whitespace around operator
Line 32:80: E501 line too long (82 > 79 characters)
Line 36:80: E501 line too long (96 > 79 characters)
Line 36:81: E225 missing whitespace around operator

Line 28:80: E501 line too long (111 > 79 characters)
Line 40:80: E501 line too long (89 > 79 characters)

Line 9:80: E501 line too long (94 > 79 characters)
Line 14:80: E501 line too long (87 > 79 characters)

Comment last updated at 2024-08-27 15:32:59 UTC

@codecov
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.84%. Comparing base (12bc644) to head (b3442bb).
Report is 12 commits behind head on main.

Files Patch % Lines
gufe/mapping/atom_mapping_scorer.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   98.94%   98.84%   -0.10%     
==========================================
  Files          36       37       +1     
  Lines        1988     1998      +10     
==========================================
+ Hits         1967     1975       +8     
- Misses         21       23       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiesBen RiesBen requested a review from richardjgowers May 6, 2024 20:52
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block pending discussion

@RiesBen RiesBen requested a review from IAlibay August 27, 2024 15:33
@RiesBen RiesBen requested a review from dotsdl September 4, 2024 08:59
@RiesBen RiesBen dismissed IAlibay’s stale review September 7, 2024 21:35

discussion were held :)

@RiesBen
Copy link
Contributor Author

RiesBen commented Sep 11, 2024

moved to Fe setup structure #346

@RiesBen RiesBen closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants