Proposal for adding get_convergence method to ProtocolResult#599
Draft
Proposal for adding get_convergence method to ProtocolResult#599
get_convergence method to ProtocolResult#599Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage 98.87% 98.88%
=======================================
Files 39 39
Lines 2321 2326 +5
=======================================
+ Hits 2295 2300 +5
Misses 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
reviewed
Aug 9, 2025
| """ | ||
| ... | ||
|
|
||
| def get_convergence(self) -> Quantity: |
Member
There was a problem hiding this comment.
This really doesn't make any sense to me. I just can't see this being widely applicable. In fact, even get_uncertainty is broken and needs a whole rethink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.