[dnm] modifications needed restoring runs and showing compound SMILES#717
Draft
jandom wants to merge 2 commits intoOpenFreeEnergy:mainfrom
Draft
[dnm] modifications needed restoring runs and showing compound SMILES#717jandom wants to merge 2 commits intoOpenFreeEnergy:mainfrom
jandom wants to merge 2 commits intoOpenFreeEnergy:mainfrom
Conversation
- don't break when directories already exists (when resuming) - add tests that confirm gufe doesn't break (doesn't actually test the resuming logic, that's vendor openmmtools) - make sure the API payloads return smiles
|
No API break detected ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of related changes that I needed to do for resuming to work.
Discussed with @dotsdl – this is just a sketch "hey here is what I needed to do"
Things breaking right now
Checklist
newsentry – @jandom what's a news entry?Developers certificate of origin