Skip to content

[dnm] modifications needed restoring runs and showing compound SMILES#717

Draft
jandom wants to merge 2 commits intoOpenFreeEnergy:mainfrom
jandom:jandom/2025-10/upstream/salad-cloud
Draft

[dnm] modifications needed restoring runs and showing compound SMILES#717
jandom wants to merge 2 commits intoOpenFreeEnergy:mainfrom
jandom:jandom/2025-10/upstream/salad-cloud

Conversation

@jandom
Copy link

@jandom jandom commented Jan 26, 2026

A bunch of related changes that I needed to do for resuming to work.

Discussed with @dotsdl – this is just a sketch "hey here is what I needed to do"

  • don't break when directory structure already already exists (when resuming)
  • add tests that confirm gufe doesn't break (doesn't actually test the resuming logic, that's vendor – specifically openmmtools)
  • make sure the API payloads return smiles, useful for GUIs consuming the results

Things breaking right now

  • easy, update tests to show that smiles is the expected output
  • hard, the tests depend on openfe, which is not otherwise a dep of this package

Checklist

  • Added a news entry – @jandom what's a news entry?

Developers certificate of origin

- don't break when directories already exists (when resuming)
- add tests that confirm gufe doesn't break (doesn't actually test the resuming logic, that's vendor openmmtools)
- make sure the API payloads return smiles
@github-actions
Copy link

No API break detected ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant