feat: return storage handles from StorageManager#718
Merged
atravitz merged 3 commits intoOpenFreeEnergy:feat/warehousefrom Jan 28, 2026
Merged
feat: return storage handles from StorageManager#718atravitz merged 3 commits intoOpenFreeEnergy:feat/warehousefrom
atravitz merged 3 commits intoOpenFreeEnergy:feat/warehousefrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/warehouse #718 +/- ##
=================================================
Coverage ? 98.33%
=================================================
Files ? 42
Lines ? 2526
Branches ? 0
=================================================
Hits ? 2484
Misses ? 42
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
atravitz
reviewed
Jan 28, 2026
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
|
No API break detected ✅ |
atravitz
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR blocks #712 by solving a logical error in how we handle passing around storage handles between
ProtocolUnits, previously users had no way to actually do this, now they do. The only thing that we may need to adjust is that this contains no metadata on which storage manager it is stored in (ie permanent vs shared), not sure if you really need it though.Checklist
newsentryDevelopers certificate of origin