[WIP] Modify execute_DAG with unitresult caching#738
Open
Conversation
Member
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
==========================================
- Coverage 98.88% 98.44% -0.44%
==========================================
Files 42 42
Lines 2685 2702 +17
==========================================
+ Hits 2655 2660 +5
- Misses 30 42 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7 tasks
|
No API break detected ✅ |
IAlibay
commented
Feb 16, 2026
| else: | ||
| # Is source key stable enough? | ||
| # We probably don't want to resume if gufe stability has changed | ||
| results[unit_result.source_key] = unit_result |
Member
Author
There was a problem hiding this comment.
Do we need to check that the unit_results are continuous?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache a JSON of each successful ProtocolUnitResult, allowing for
execute_DAGto resume when called over a DAG that hasn't been fully executed.Checklist
newsentryDevelopers certificate of origin