Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 92.24% 94.01% +1.76%
==========================================
Files 84 88 +4
Lines 2618 3392 +774
==========================================
+ Hits 2415 3189 +774
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
f43ea1a to
a40ef73
Compare
b1ba346 to
5adc4d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corresponds to OpenFreeEnergy/openfe#1522
resolves OpenFreeEnergy/openfe#1397 as well.
This PR will be followed by significant viz cleanup and consolidation, but the priority for this PR is to move code out of openfe.
NOTE: longer term, I could see this living in gufe, but short-term, I'd like to be able to iterate more quickly with network viz things in konnektor before we move to gufe.
PR Author Checklist
pre-commit.ci autofixwhen the PR is ready for reviewTips
Since this will create a commit, it is best to make this comment when you are finished with your work.
Developers certificate of origin
Reviewer Checklist