deprecate concatenate_networks standalone function in favor of class methods#208
Merged
deprecate concatenate_networks standalone function in favor of class methods#208
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
+ Coverage 92.24% 92.32% +0.08%
==========================================
Files 84 84
Lines 2618 2633 +15
==========================================
+ Hits 2415 2431 +16
+ Misses 203 202 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mikemhenry
reviewed
Feb 3, 2026
Contributor
mikemhenry
left a comment
There was a problem hiding this comment.
LGTM! I couldn't even find reference to the use in indy b-mark repo
mikemhenry
approved these changes
Feb 3, 2026
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this helper method doesn't actually add any additional functionality, and should be removed.
PR Author Checklist
pre-commit.ci autofixto auto-format your PR).Tips
pre-commit.ci autofixto have pre-commit.ci auto-format your PR.Since this will create a commit, it is best to make this comment when you are finished with your work.
Developers certificate of origin
Reviewer Checklist