Skip to content

deprecate concatenate_networks standalone function in favor of class methods#208

Merged
atravitz merged 7 commits intomainfrom
remove_standalone_concatenator
Feb 3, 2026
Merged

deprecate concatenate_networks standalone function in favor of class methods#208
atravitz merged 7 commits intomainfrom
remove_standalone_concatenator

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Jan 26, 2026

I believe this helper method doesn't actually add any additional functionality, and should be removed.

PR Author Checklist

  • added news item, or changes are not user-facing
  • pre-commit CI passes (comment pre-commit.ci autofix to auto-format your PR).

Tips

  • Comment pre-commit.ci autofix to have pre-commit.ci auto-format your PR.
    Since this will create a commit, it is best to make this comment when you are finished with your work.

Developers certificate of origin

Reviewer Checklist

  • news entry has been added if necessary
  • pre-commit auto fix has been run
  • any API breaks have been documented

@atravitz atravitz requested a review from mikemhenry January 26, 2026 23:37
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.32%. Comparing base (2dbeb3a) to head (f2feabd).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   92.24%   92.32%   +0.08%     
==========================================
  Files          84       84              
  Lines        2618     2633      +15     
==========================================
+ Hits         2415     2431      +16     
+ Misses        203      202       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz changed the title remove concatenate_networks standalone function in favor of class methods deprecate concatenate_networks standalone function in favor of class methods Feb 3, 2026
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I couldn't even find reference to the use in indy b-mark repo

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@atravitz atravitz enabled auto-merge (squash) February 3, 2026 19:58
@atravitz atravitz merged commit f7637fb into main Feb 3, 2026
8 checks passed
@atravitz atravitz deleted the remove_standalone_concatenator branch February 3, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants