Skip to content

Refactor/update test names for clarity#211

Merged
atravitz merged 7 commits intomainfrom
refactor/update_test_names_for_clarity
Feb 3, 2026
Merged

Refactor/update test names for clarity#211
atravitz merged 7 commits intomainfrom
refactor/update_test_names_for_clarity

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Jan 27, 2026

Just a bunch of renaming to make things clearer.

PR Author Checklist

  • added news item, or changes are not user-facing
  • pre-commit CI passes (comment pre-commit.ci autofix to auto-format your PR).

Tips

  • Comment pre-commit.ci autofix to have pre-commit.ci auto-format your PR.
    Since this will create a commit, it is best to make this comment when you are finished with your work.

Developers certificate of origin

Reviewer Checklist

  • news entry has been added if necessary
  • pre-commit auto fix has been run
  • any API breaks have been documented

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.33%. Comparing base (f7637fb) to head (4a2fc31).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/konnektor/utils/toy_data.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   92.32%   92.33%           
=======================================
  Files          84       84           
  Lines        2633     2634    +1     
=======================================
+ Hits         2431     2432    +1     
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz marked this pull request as ready for review February 2, 2026 18:32
@atravitz atravitz requested a review from mikemhenry February 2, 2026 18:32
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I do think it could make sense to fix 2 of the class names

@atravitz atravitz enabled auto-merge (squash) February 3, 2026 20:10
@atravitz
Copy link
Contributor Author

atravitz commented Feb 3, 2026

LGTM, I do think it could make sense to fix 2 of the class names

done, thanks!!

@atravitz atravitz merged commit 8103e3d into main Feb 3, 2026
8 checks passed
@atravitz atravitz deleted the refactor/update_test_names_for_clarity branch February 3, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants