Open
Conversation
openfe_benchmarks/results/submissions/2026_02_10_Sage_2.3.0_rbfes/data/bace/bace_ref.csv
Outdated
Show resolved
Hide resolved
openfe_benchmarks/results/submissions/2026_02_10_Sage_2.3.0_rbfes/data/bace/bace_ref.csv
Outdated
Show resolved
Hide resolved
openfe_benchmarks/results/submissions/2026_02_10_Sage_2.3.0_rbfes/data/gather.py
Outdated
Show resolved
Hide resolved
..._benchmarks/results/submissions/2026_02_10_Sage_2.3.0_rbfes/data/openff-2.3.0rc2_nagl_dG.csv
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is an updated submission readme and maybe a first submission.
You'll notice that currently the README describes one ddG and one dG per submission. Does that make sense, or will it be more like the data structure currently for Sage 2.3.0 on Zenodo. If one gathered ddG and dG are expected, how will the format be standardized? The files currently compiled for the different partial charges have headers in different orders.
It would be great if we can make a
BenchmarkResultclass to (1) validate contents with pytest and (2) allow users to browse data and pythonically pull and compare. I don't know about you but looking through QCADS is a pain and there's barely a reason that I need to.