Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1082 +/- ##
==========================================
+ Coverage 90.75% 91.84% +1.08%
==========================================
Files 142 142
Lines 10528 10527 -1
==========================================
+ Hits 9555 9668 +113
+ Misses 973 859 -114
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
left a comment
There was a problem hiding this comment.
This seems find to me thanks!
More tests / logging would be great, but I don't think we have to do them here (or that they should hold off the release).
|
No API break detected ✅ |
|
Thanks @IAlibay - I just switched from the |
Could you possibly open up an issue about the openeye issues? I'm not sure we have any and it feels like we circle around them a lot recently. |
This shouldn't be happening by default - unless we're using NAGL for charge generation. |
closes #1070
blocked by OpenFreeEnergy/Lomap#62, need to release a minor version of lomap and pin openfe to that version as a minimum.
Checklist
newsentryDevelopers certificate of origin