Add a note on charge generation during CLI workflows#1117
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
- Coverage 93.51% 91.87% -1.65%
==========================================
Files 142 142
Lines 10608 10608
==========================================
- Hits 9920 9746 -174
- Misses 688 862 +174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jthorton
commented
Feb 7, 2025
jthorton
commented
Feb 7, 2025
atravitz
reviewed
Feb 11, 2025
Contributor
atravitz
left a comment
atravitz
left a comment
There was a problem hiding this comment.
just two typos, then lgtm!
atravitz
approved these changes
Feb 11, 2025
|
No API break detected ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a note to inform users of the CLI that we are now generating charges when planning networks. I have also added a link to the new tutorial in example notebooks which should be merged first OpenFreeEnergy/ExampleNotebooks#187
Checklist
newsentryDevelopers certificate of origin