[DNM] test to see if new number solver works in openfe#1843
[DNM] test to see if new number solver works in openfe#1843mikemhenry wants to merge 2 commits intomainfrom
Conversation
|
🚨 API breaking changes detected! 🚨 |
|
@mikemhenry none of our tests would catch this properly - the only way we would know is by running actual simulations. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
- Coverage 95.22% 92.98% -2.25%
==========================================
Files 204 204
Lines 17623 17623
==========================================
- Hits 16781 16386 -395
- Misses 842 1237 +395
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
They aren't going to be enough in this case - the memory issues we've had in the past are when you run a full length simulation. |
|
I'm not trying to validate this accelerator in just this PR, but these tests will catch issues with env solving, code bugs, etc. |
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin