Improve timeout handling

[salbahra]

Summary

• retry transient ETIMEDOUT errors in OpenGarageApi
• remove unused dependency in open_garage.js
• fix default references in tests
• run mocha via npm test

Testing

• npm test (fails: Service.OccupancySensor is not a constructor)

---

https://chatgpt.com/codex/tasks/task_e_684380276384832cb099697ad6529ff7

[Copilot]

Pull Request Overview

This PR enhances timeout handling by retrying transient errors in the API module, cleans up unused dependencies, updates test defaults, and sets up Mocha as the test runner.

• Added _request wrapper in open_garage_api.js to retry on ECONNRESET and ETIMEDOUT
• Updated test defaults to use *Secs * 1000 for poll frequency and open/close duration
• Removed unused request-promise-native import in open_garage.js and changed the npm test script to run Mocha

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
test/open_garage_test.js	Adjusted default timing values to use seconds-based settings × 1000
package.json	Updated "test" script to invoke mocha
lib/open_garage_api.js	Introduced http.Agent and retry logic for transient timeout errors
lib/open_garage.js	Removed unused request-promise-native import comment

[Copilot]

[nitpick] The declaration uses var while pollFrequencyMs uses let. Consider using let or const for consistency and block scoping.

Suggested change

	var openDurationMs = OpenGarageModule.defaults.openCloseDurationSecs * 1000
	let openDurationMs = OpenGarageModule.defaults.openCloseDurationSecs * 1000

[Copilot]

[nitpick] Remove this commented-out import to clean up the code and avoid confusion, as it's no longer used.

Suggested change

// request-promise-native was previously required here but never used

[Copilot]

[nitpick] Retries occur immediately without delay. Consider adding a short delay (e.g., using setTimeout) between retries to avoid rapid-fire requests.

Suggested change

	return this._request(options, retries - 1)
	return new Promise((resolve) => {
	setTimeout(() => resolve(this._request(options, retries - 1)), 100);
	});