Open
Conversation
soc221b
suggested changes
Mar 16, 2018
| if request.method == 'GET': | ||
| query = re.escape(request.GET['q']).replace('\ ', ' ') | ||
|
|
||
| #add |
There was a problem hiding this comment.
Please remove comments that such this, since the diff will highlight those new code line or modified one.
| return all_insert(X[0], e) + for_each(X[1:],e) if X else [] | ||
|
|
||
| def permute(x): | ||
| return [x] if len(x) < 2 else for_each( permute(x[1:]) , x[0]) |
There was a problem hiding this comment.
Standard libs have already implemented this.
Contributor
Author
There was a problem hiding this comment.
@iattempt Just updated the comments.
Member
|
The Travis Build must pass to get this merged. You have made an important contribution which will improve the search results. Kindly take a look at the errors here and make suitable changes. 👍 |
winlover32
approved these changes
Jan 19, 2024
winlover32
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
developbranch.Which issue does this PR fix?:
fixes: #70
This PR resolves issue #70 (The random keywords in search box aren't always having a search result).
Why do we need this PR?:
For keyword linear search, the permutations generated must be linear_search, search_linear, linear and search. The search should be able to handle such cases. We aim to broaden the search experience of users through this PR and the PRs that follow.
Thanks,
Team GalSquared | RGSoC